Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WASMEDGE_ID bug #2194

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Fix WASMEDGE_ID bug #2194

merged 2 commits into from
Aug 27, 2024

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Aug 26, 2024

Description of the Change

WASMEDGE_ID was declared in CMake in the Hunter config directory scope, thus not visible where it was supposed to be added as a compiler definition to WasmEdge module factory .cpp.

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No

@Harrm Harrm marked this pull request as ready for review August 26, 2024 11:48
@Harrm Harrm requested review from zerg-su and turuslan August 26, 2024 11:48
@Harrm Harrm merged commit 1240c82 into master Aug 27, 2024
13 checks passed
@Harrm Harrm deleted the fix/wasmedge-id branch August 27, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants